Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3489)!: remove cursor close options #3505

Merged
merged 3 commits into from
Jan 3, 2023
Merged

feat(NODE-3489)!: remove cursor close options #3505

merged 3 commits into from
Jan 3, 2023

Conversation

durran
Copy link
Member

@durran durran commented Dec 27, 2022

Description

Removes CursorCloseOptions.

What is changing?

  • Removes the CursorCloseOptions and updates the close() method to no longer take options.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-3489

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the wip label Dec 27, 2022
@durran durran removed the wip label Dec 28, 2022
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 3, 2023
@baileympearson baileympearson self-requested a review January 3, 2023 18:24
@baileympearson
Copy link
Contributor

Failing mongosh tests are expected and a devtools ticket has been created.

@baileympearson baileympearson merged commit 88c03a1 into main Jan 3, 2023
@baileympearson baileympearson deleted the NODE-3489 branch January 3, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
3 participants
@durran @baileympearson @nbbeeken