Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6066): signature can be optional at runtime #4069

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix(NODE-6066): signature can be optional at runtime #4069

merged 2 commits into from
Apr 4, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 4, 2024 •
edited

Description

What is changing?

  • Correct typescript for signature property on ClusterTime interface
Is there new documentation needed for these changes?

No.. well yes, these are docs changes!

What is the motivation for this change?

Release Highlight

ClusterTime interface signature optionality

The ClusterTime interface incorrectly reported the signature field as required, the server may omit it, so the typescript has been updated to reflect reality.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken mentioned this pull request Apr 4, 2024
Merged
5 tasks
@baileympearson baileympearson self-assigned this Apr 4, 2024
@baileympearson baileympearson merged commit ce55ca9 into main Apr 4, 2024
17 of 26 checks passed
@baileympearson baileympearson deleted the NODE-6066-signature branch April 4, 2024 21:13
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
Merged
baileympearson pushed a commit to baileympearson/node-mongodb-native that referenced this pull request Apr 15, 2024
@nbbeeken @baileympearson
fix(NODE-6066): ClusterTime.signature can be undefined (mongodb#4069)
a91ce39
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request May 24, 2024
Merged
@tdbaine tdbaine mentioned this pull request May 24, 2024
Open
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@calvin-kimani calvin-kimani mentioned this pull request May 24, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 25, 2024
Open
@DenoneroDev DenoneroDev mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 25, 2024
Closed
@prernaadev01 prernaadev01 mentioned this pull request May 25, 2024
Closed
@James220903 James220903 mentioned this pull request May 25, 2024
Open
@lydmoon lydmoon mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 26, 2024
Open
@mkusztal mkusztal mentioned this pull request May 27, 2024
Open
@lydmoon lydmoon mentioned this pull request May 27, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 27, 2024
Open
@mkusztal mkusztal mentioned this pull request May 28, 2024
Open
@lryanle lryanle mentioned this pull request May 28, 2024
Open
@boytur boytur mentioned this pull request May 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 28, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request May 29, 2024
Closed
@hatifmujahid hatifmujahid mentioned this pull request May 30, 2024
Merged
@prernaadev01 prernaadev01 mentioned this pull request May 31, 2024
Closed
@anand-py anand-py mentioned this pull request Jun 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nbbeeken @baileympearson