fix(NODE-7232): only send endSessions during client close if the topology supports sessions #4722
+159
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-7232
branch
from
25bf8f4 to
25de3df
Compare
durran
added
the
Primary Review
durran
requested changes
Oct 10, 2025
durran
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
MongoClient.close() no longer sends endSessions if the topology does not have session support
MongoClient.close()attempts to free up any server resources that the client has instantiated, including sessions. Previously,MongoClient.close()unconditionally attempted to killall sessions, regardless of whether or not the topology actually supports sessions.Now,
MongoClient.close()only attempts to clean up sessions if the topology supports sessions.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript