feat: support speculative authentication in scram-sha and x509 #2353
Conversation
This introduces a new auth provider stage `prepare` which allows a provider to alter the handshake document before its used for the initial handshake. The SCRAM-SHA and X509 providers have been improved to use the prepare stage in order to speculatively authenticate, potentially reducing the roundtrips of connection authentication. NODE-2487
mbroadst
force-pushed
the
NODE-2487/master/speculative-authentication
branch
from
996c97a
to
f754f15
Compare
| return; | ||
| } | ||
|
|
||
| const { connection, credentials } = authContext; |
There was a problem hiding this comment.
Could go a bit further with destructuring here and get rid of credentials, which isn't used again past here.
const { connection, credentials: { username, password, mechanismProperties } } = authContext;
There was a problem hiding this comment.
I thought we decided against the deep destructuring in one of Neal's PRs, because it would hose TypeScript?
There was a problem hiding this comment.
Possibly, but I don't recall that discussion. Do you remember the details of how it would hose Typescript (or perhaps you do @nbbeeken)?
There was a problem hiding this comment.
There's no issue with doing this with TS. The discussion we had is that you can't use this nested destructuring with ES6 imports, which is potentially something we'd have to use in some far off future. So I had reverted some of the requires to just use one layer of destructuring, but that didn't make it in.
this is the port to 4.0
This introduces a new auth provider stage
preparewhich allows a provider to alter the handshake document before its used for the initial handshake. The SCRAM-SHA and X509 providers have been improved to use the prepare stage in order to speculatively authenticate, potentially reducing the roundtrips of connection authentication.NODE-2487