fix: Use getters to sync BulkWriteResult wrappers #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds getters so that mergeBatchResults changes are reflected in wrapper classes. NODE-3055
emadum
approved these changes
Jan 27, 2021
test/functional/insert.test.js
Outdated
| @@ -2583,4 +2584,45 @@ describe('Insert', function () { | |||
| }); | |||
| } | |||
| }); | |||
|
|
|||
| it('MongoBulkWriteError.insertedCount should respect BulkWriteResult.insertedCount should respect BulkWrite.nInserted', function () { | |||
There was a problem hiding this comment.
Suggested change
| it('MongoBulkWriteError.insertedCount should respect BulkWriteResult.insertedCount should respect BulkWrite.nInserted', function () { | |
| it('MongoBulkWriteError.insertedCount should respect BulkWrite.nInserted', function () { |
There was a problem hiding this comment.
I'll give this a better name but this was actually correct MongoBulkWriteError holds a BulkWriteResult which holds the BulkWrite so this test makes sure the values thread correctly through the two wrapping classes
|
I mentioned in stand-up being concerned about printing these classes out being changed, so to follow up Here's what it looks like on this fix: {
name: 'MongoBulkWriteError',
code: 11000,
writeErrors: [ WriteError { err: [Object] } ],
result: BulkWriteResult {
result: {
ok: 1,
writeErrors: [Array],
writeConcernErrors: [],
insertedIds: [Array],
nInserted: 2,
nUpserted: 0,
nMatched: 0,
nModified: 0,
nRemoved: 0,
upserted: []
}
}
}Version 3.6 {
driver: true,
code: 11000,
writeErrors: [ WriteError { err: [Object] } ],
result: BulkWriteResult {
result: {
ok: 1,
writeErrors: [Array],
writeConcernErrors: [],
insertedIds: [Array],
nInserted: 2,
nUpserted: 0,
nMatched: 0,
nModified: 0,
nRemoved: 0,
upserted: []
}
}
}Essentially the same and it contains the information you would most likely be looking for |
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Adds getters so that mergeBatchResults changes are reflected in wrapper classes. NODE-3055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds getters so that mergeBatchResults changes are reflected in wrapper
classes.
NODE-3055
Came across this bug while working on unified tests, these properties are new in 4.0 so this doesn't need a backport.