Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: restrict destroy test to node v8 and up #2728

Merged
merged 1 commit into from
Feb 8, 2021
Merged

test: restrict destroy test to node v8 and up #2728

merged 1 commit into from
Feb 8, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Feb 2, 2021 •
edited
Loading

Note: writable.destroy was added in node v8.0.0

NODE-3065

@emadum emadum changed the title chore(ci): address test failures test: restrict stream.destroy test to node 8 and up Feb 4, 2021
@emadum emadum marked this pull request as ready for review February 4, 2021 16:15
@emadum emadum changed the title test: restrict stream.destroy test to node 8 and up test: skip failing tests Feb 4, 2021
@emadum emadum marked this pull request as draft February 4, 2021 18:09
@emadum emadum changed the title test: skip failing tests test: restrict destroy test to node v8 and up Feb 8, 2021
@emadum emadum marked this pull request as ready for review February 8, 2021 15:13
nbbeeken
nbbeeken approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was the changes to the PR ^ just hunting down the source of the problem?

@emadum
Copy link
Contributor Author

emadum commented Feb 8, 2021

LGTM, was the changes to the PR ^ just hunting down the source of the problem?

There were some failures in the CSFLE tests that I wanted to include a fix for as part of this PR, but that turned out to be an error in the Evergreen project settings and didn't need any code changes.

@emadum emadum merged commit e8ac558 into 3.6 Feb 8, 2021
@emadum emadum deleted the NODE-3065/fix-tests-for-ci branch February 8, 2021 17:47
This was referenced Mar 16, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emadum @nbbeeken