fix(operations): fix deprecation warning in Node.js 14 #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
added a commit
to Automattic/mongoose
that referenced
this pull request
Feb 8, 2021
|
Thanks for helping out! since this is a duplicate of #2734 we'll just go with that one since it came in first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
#2626 introduced a deprecation warning in Node.js 14 due to a circular import, because
../core/index.jseventually importsoperations/operation.js. This works around the deprecation warning and makes sureMongoErroris actually defined in this file.Are there any files to ignore?
Nope