Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3150): added bsonRegExp option for v3.6 #2843

Merged
merged 6 commits into from
Jun 28, 2021
Merged

fix(NODE-3150): added bsonRegExp option for v3.6 #2843

merged 6 commits into from
Jun 28, 2021

Conversation

andymina
Copy link
Contributor

@andymina andymina commented Jun 15, 2021 •
edited
Loading

Description

  • Allowed retrieving PCRE-style RegExp by adding bsonRegExp option to commands, collections, and dbs
  • Added unit tests for the bsonRegExp option

@andymina andymina marked this pull request as ready for review June 15, 2021 19:39
@andymina andymina marked this pull request as draft June 15, 2021 19:40
@andymina andymina marked this pull request as ready for review June 17, 2021 00:11
@andymina andymina added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 17, 2021
@andymina andymina marked this pull request as draft June 18, 2021 01:09
@andymina andymina removed the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 18, 2021
@andymina andymina marked this pull request as ready for review June 22, 2021 15:20
@andymina andymina requested a review from durran June 22, 2021 15:24
@andymina andymina added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 22, 2021
@durran durran self-assigned this Jun 24, 2021
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 24, 2021
@durran durran requested review from a team, emadum, nbbeeken and durran and removed request for a team June 24, 2021 12:26
@durran durran changed the base branch from 3.6 to 3.7 June 24, 2021 12:49
durran
durran approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved base branch back to 3.6

@durran durran changed the base branch from 3.7 to 3.6 June 24, 2021 14:12
nbbeeken
nbbeeken requested changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note so we can remember, there's some refactoring needed for the older node versions in the test. (i.e. cant use async)

@andymina andymina requested a review from nbbeeken June 25, 2021 17:22
@nbbeeken nbbeeken requested a review from dariakp June 25, 2021 17:55
dariakp
dariakp requested changes Jun 25, 2021
View reviewed changes
test/unit/bson_regex.test.js Outdated Show resolved Hide resolved
@andymina andymina requested a review from dariakp June 25, 2021 18:50
dariakp
dariakp requested changes Jun 25, 2021
View reviewed changes
test/unit/bson_regex.test.js Outdated Show resolved Hide resolved
@andymina andymina requested a review from dariakp June 25, 2021 20:06
emadum
emadum approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@durran durran merged commit e4a9a57 into 3.6 Jun 28, 2021
@durran durran deleted the NODE-3150/bson-regex-3.6 branch June 28, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@emadum emadum emadum approved these changes

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andymina @durran @emadum @nbbeeken @dariakp