Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3380): perform retryable write checks against server #2861

Merged
merged 3 commits into from
Jun 29, 2021
Merged

fix(NODE-3380): perform retryable write checks against server #2861

merged 3 commits into from
Jun 29, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jun 25, 2021 •
edited
Loading

The driver was incorrectly checking for a Single topology instead of
a Standalone server when determining the retryability of write
operations.

NODE-3380

@emadum emadum force-pushed the NODE-3380/3.6/fix-retryable-write-check branch from b94d4b0 to 9fad251 Compare June 25, 2021 00:39
@emadum emadum marked this pull request as ready for review June 25, 2021 18:58
@emadum emadum requested a review from nbbeeken June 28, 2021 16:23
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 28, 2021
nbbeeken
nbbeeken requested changes Jun 28, 2021
View reviewed changes
lib/core/sdam/topology.js Show resolved Hide resolved
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 28, 2021
@nbbeeken nbbeeken requested a review from durran June 28, 2021 17:58
@nbbeeken nbbeeken merged commit 621677a into 3.6 Jun 29, 2021
@nbbeeken nbbeeken deleted the NODE-3380/3.6/fix-retryable-write-check branch June 29, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @durran @nbbeeken