fix(NODE-3463): pass explain error through to callback #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
force-pushed
the
NODE-3463/3.7/fix-uncaught-explain-unified
branch
from
d720c4b
to
559f078
Compare
dariakp
reviewed
Aug 24, 2021
nbbeeken
reviewed
Aug 25, 2021
| if (explain) { | ||
| findCmd = decorateWithExplain(findCmd, explain); | ||
| try { | ||
| const explain = Explain.fromOptions(options); |
There was a problem hiding this comment.
NODE-3377
Totally expanding scope here but we're validating too strictly here, this could be a quick fix that goes in this PR, we just need to assert string or boolean.
There was a problem hiding this comment.
Let's not do that in this PR because while a "quick fix", it also should come with its own test, and probably merits its own line in bug fix release notes. I don't object to getting it into 3.7 as a follow up PR, but let's keep small things small.
dariakp
approved these changes
Aug 25, 2021
nbbeeken
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.