chore(NODE-3719,NODE-3883): identify causal consistency spec tests #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
commented
Jan 20, 2022
test/integration/causal-consistency/causal_consistency.prose.test.js
Outdated
Show resolved
Hide resolved
dariakp
force-pushed
the
NODE-3719/spec-compliance-causal-consistency-tests
branch
from
888fda8
to
36bfe7f
Compare
dariakp
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
approved these changes
Jan 21, 2022
| { | ||
| metadata: { | ||
| requires: { topology: ['replicaset', 'sharded'] }, | ||
| // Skipping session leak tests b/c these are explicit sessions |
There was a problem hiding this comment.
This is interesting, I would think this test still clean up the sessions it creates
nbbeeken
requested review from
durran and
baileympearson
and removed request for
durran and
baileympearson
nbbeeken
deleted the
NODE-3719/spec-compliance-causal-consistency-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3719, NODE-3883
What is changing?
Identifying implemented and missing causal consistency spec tests; spec also says we should run on sharded topologies, not just replica set, so I expanded the required topology list.
Is there new documentation needed for these changes?
N/A
What is the motivation for this change?
Spec compliance audit
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>