-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-5064): consolidate connection cleanup logic and ensure socket is always closed #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-5064
branch
from
February 15, 2023 18:39
1f5e499
to
affbd1f
Compare
baileympearson
commented
Feb 15, 2023
baileympearson
changed the title
make DestroyOptions required on connection.destroy
fix(NODE-5064): consolidate connection cleanup logic
Feb 15, 2023
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Feb 15, 2023
baileympearson
changed the title
fix(NODE-5064): consolidate connection cleanup logic
fix(NODE-5064): consolidate connection cleanup logic and ensure socket is always closed
Feb 15, 2023
addaleax
previously approved these changes
Feb 15, 2023
nbbeeken
reviewed
Feb 15, 2023
nbbeeken
requested changes
Feb 15, 2023
nbbeeken
requested changes
Feb 16, 2023
nbbeeken
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Feb 16, 2023
nbbeeken
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR primarily does three things:
Example unit test output:
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript