-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5470)!: convert remaining FLE to TS and drop support for onKMSProvidersRefresh
#3787
Merged
nbbeeken
merged 47 commits into
mongodb:main
from
baileympearson:node-5470-typescript-remaining-fle
Aug 3, 2023
Merged
feat(NODE-5470)!: convert remaining FLE to TS and drop support for onKMSProvidersRefresh
#3787
nbbeeken
merged 47 commits into
mongodb:main
from
baileympearson:node-5470-typescript-remaining-fle
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Jul 27, 2023
baileympearson
commented
Jul 27, 2023
baileympearson
commented
Jul 27, 2023
baileympearson
changed the title
Node 5470 typescript remaining fle
feat!(NODE-5470): convert remaining FLE to TS and drop support for Jul 31, 2023
onKMSProvidersRefresh
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jul 31, 2023
nbbeeken
changed the title
feat!(NODE-5470): convert remaining FLE to TS and drop support for
feat(NODE-5470)!: convert remaining FLE to TS and drop support for Jul 31, 2023
onKMSProvidersRefresh
onKMSProvidersRefresh
nbbeeken
requested changes
Jul 31, 2023
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
nbbeeken
requested changes
Aug 2, 2023
nbbeeken
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The remaining FLE files and tests are converted to TS. Additional changes:
utils.ts
.once
andchild_process
are lazily imported in the state machine and mongodbcyptd manager, respectivelydatabaseNamespace
andcollectionNamespace
have been removed in favor ofMongoDBNamespace
.One other notable change is that when we fail to get kms provider information, the error thrown used to attach an
originalError
property. I adjusted this to use the error'scause
, since Node16+ and MongoCryptErrors support thecause
property.I also removed support for
onKMSProvidersRefresh
here.Is there new documentation needed for these changes?
No, documentation is coming in a follow up.
What is the motivation for this change?
Release Highlight
ClientEncryption.onKMSProvidersRefresh
function removedClientEncryption.onKMSProvidersRefresh
was added as a public API in version 2.3.0 ofmongodb-client-encryption
to allow for automatic refresh of KMS provider credentials. Subsequently, we've added the capability to automatically refresh KMS credentials using the KMS provider's preferred refresh mechanism, andonKMSProviderRefresh
is no longer used.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript