Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4598 adds support to use Noto Sans for Japanese Docs Sites #1088

Merged
merged 4 commits into from
May 8, 2024

Conversation

caesarbell
Copy link
Collaborator

Stories/Links:

DOP-4598

Current Behavior:

N/A

Staging Links:

Japanese Stagged Commit Site

Notes:

I left a comment here asking about adding Japanese to the language selector. Currently, we only provide the following languages to our users when visiting the docs pages.

  • English
  • Simplified Chinese
  • Korean
  • Portuguese

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for staging too!

@caesarbell caesarbell merged commit daf26a7 into main May 8, 2024
2 checks passed
@caesarbell caesarbell deleted the DOP-4598 branch May 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants