-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesarbell
changed the title
[DOP-4671 Merge in DOP-4671 First] DOP-4672
[Merge in DOP-4671 First] : DOP-4672
May 28, 2024
seungpark
reviewed
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM, as far as changes independent from DOP-4671. minor comments below but overall looks great!
mmeigs
reviewed
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Two overall nits:
- Make sure not to merge until you've first merged in the change I asked for in DOP-4667 PR
- Remember to add context to the title of the PR
caesarbell
changed the title
[Merge in DOP-4671 First] : DOP-4672
[Merge in DOP-4667 First] : DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context
May 29, 2024
caesarbell
changed the title
[Merge in DOP-4667 First] : DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context
DOP-4672 - Allows the background styles to be influenced by the dark mode value from it's context
May 29, 2024
mmeigs
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4672
Current Behavior:
Atlas
Staging Links:
Stagged Atlas
Notes:
README updates