Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4603: Add Japanese locale behind feature flag #1106

Merged
merged 2 commits into from
Jun 3, 2024
Merged

DOP-4603: Add Japanese locale behind feature flag #1106

merged 2 commits into from
Jun 3, 2024

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented May 31, 2024

Stories/Links:

DOP-4603

Current Behavior:

Atlas docs prod

Staging Links:

With feature flag ON - should include Japanese in the locale selector and hreflang links
With feature flag OFF - should be the same as prod
Japanese site example - to validate that the locale selector shows the Japanese language as the selected locale.

Notes:

  • Conditionally adds Japanese to the list of languages through a feature flag. This should automatically handle adding Japanese to both the locale selector and the hreflang links for SEO.
  • Not adding it to the redirects list in the head script for now due to the limitation of not being allowed to use exports and not being able to access process.env for the feature flag. We'll most likely need to add it to the list later, whenever it's time for launch.

To test

  1. Add GATSBY_FEATURE_SHOW_HIDDEN_LOCALES=true in your .env.* files.
  2. Develop or build the docs.
  3. Check that Japanese ("日本語") is now in the locale selector and can be clicked. Clicking should prepend ja-jp to the URL's pathname.
  4. Check that an hreflang link for ja-jp is now present in the head tag of the HTML in both the DOM and in the page source.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@rayangler rayangler marked this pull request as ready for review May 31, 2024 21:36
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rayangler rayangler merged commit 2d416dd into main Jun 3, 2024
2 checks passed
@rayangler rayangler deleted the DOP-4603 branch June 3, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants