-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4540: Simplify versioned prefix generation #1113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeigs
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comments!! Raymund, this is so clean. Looks great.
caesarbell
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4540
Current Behavior:
Server docs prod
Atlas docs prod
Staging links to compare with for
main
branch:Server docs staging - built with dotcomprd, without path prefix
Server docs staging - built with default dev
Staging Links:
Atlas docs - built with dotcomprd, without path prefix
Server docs - built with dotcomprd, without path prefix
Server docs - built with default dev
Notes:
SNOOTY_ENV
environment declared in order to see accurate version prefix generation for canonicals and version dropdown URLs. This should make the canonicals and version dropdowns more reflective of behavior on a deployed site.generatePrefix
util function to begenerateVersionedPrefix
to semantically decouple it from the version dropdown component. The function should be used specifically for URLs to other versions of the same site project, whilewithPrefix
can continue to be used for URLs for the same/current version of the site.README updates