DOP-4623: Dark mode for Cards #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesarbell
approved these changes
Jun 6, 2024
| @@ -155,11 +157,26 @@ const Card = ({ | |||
| isLanding && !isLargeIconStyle ? landingStyles : '', // must come after other styles to override | |||
| ]; | |||
|
|
|||
| let iconSrc; | |||
There was a problem hiding this comment.
(nit) I wonder if by reducing the nested if statements and using ternary operators, we could make the code cleaner and more readable. Maybe something like;
let iconSrc;
if (icon) {
const isPath = icon.includes('/');
const getIcon = `${icon}${darkMode ? '_inverse' : ''}`;
const webImageURL = `https://webimages.mongodb.com/_com_assets/icons/${getIcon}.svg`;
iconSrc = isPath
? (darkMode && iconDark ? withPrefix(iconDark) : withPrefix(icon))
: webImageURL;
}If you don't agree, please feel free to ignore it as this is not a blocker.
There was a problem hiding this comment.
beautiful! thank you :)
mmeigs
approved these changes
Jun 6, 2024
| border-radius: 24px; | ||
| font-family: 'Euclid Circular A',Akzidenz,'Helvetica Neue',Helvetica,Arial,sans-serif; |
There was a problem hiding this comment.
omg thank god, get that dark-sided name outta here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4623
Current Behavior:
Current docs compass landing page
Current drivers landing page
Staging Links:
Docs compass (built off of this PR)
Drivers landing page (built off of this PR)
Notes:
Figma
Upgrades Card component to support Dark Mode, as well as adds functionality to either get the card icon from the version stored in the content repo, or get it from the Web team's URL (which pulls from this list), which enables easier access to dark mode images since we can just add
_inverseinstead of having to include both the light mode and dark mode versions of the images. See Parser PR here.The driver cards in the docs-landing IA, while written as card directives in the rST, are actually SideNavItems so I will leave those out of the scope of this ticket.
Additional work should probably involve having a fallback image when the inverse image doesn't exist.
README updates