Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4643: strict rules for image borders #1129

Merged
merged 4 commits into from
Jun 12, 2024
Merged

DOP-4643: strict rules for image borders #1129

merged 4 commits into from
Jun 12, 2024

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Jun 12, 2024

Stories/Links:

DOP-4643

Current Behavior:

previous staged link showed borders around hero image in dark mode

Staging Links:

docs landing
language pages from docs landing
atlas docs
atlas docs with image example
regression check

Notes:

  • Adds checks to see if this is a landing page or sectionDepth must be greater than 2 to apply border styling in dark mode only

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@seungpark seungpark marked this pull request as ready for review June 12, 2024 17:58
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seungpark seungpark merged commit 578202f into main Jun 12, 2024
2 checks passed
@seungpark seungpark deleted the DOP-4643-followup branch June 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants