-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dark Mode]: Search page #1147
[Dark Mode]: Search page #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks amazing. I just had some questions and some minor suggestions.
} | ||
:visited { | ||
${StyledResultTitle} { | ||
color: ${searchResultTitleColorOnVisited}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want to use Purple/Base
for the first <p>
in the card, when it has been visited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you think it should be the base? It is purple. Different purples depending on the darkMode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. minor comments below but generally looks clean!
Stories/Links:
DOP-4697
Current Behavior:
Search
Staging Links:
Search
Notes:
Enables dark mode for Search page. Follows Figma.
README updates