Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4784-B: Remove chatbot FAB from 404, use ChatbotUi bar #1162

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Jul 11, 2024

Stories/Links:

DOP-4784 (b)

Current Behavior:

Landing
Cloud-docs
404

Staging Links:

Landing
Cloud-docs
404

Notes:

This is a re-do of DOP-4784.

I had previously added the Chatbot FAB to the 404 page. What is actually needed is the ChatbotUI bar.

This PR removes the FAB from the 404. It also adds the ChatbotUi component to the 404 page.

In doing so, there were styling differences between the landing template and the errorpage template that needed to be addressed to match the design requirements listed in the ticket's comments. The chatbot bar needed to match the width of the page elements which currently are simply justified to center no matter the width of the div. The changes in this PR cement the widths of the divs in the main section so that the chatbot bar can match their widths in all screensizes.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Changes generally look good. Just wanted to ask some questions before formally approving

src/templates/NotFound.js Show resolved Hide resolved
src/components/ChatbotUi.js Show resolved Hide resolved
@mmeigs mmeigs requested a review from rayangler July 12, 2024 14:09
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to check in with Sarah Lin to make sure these changes are okay, but otherwise LGTM

@mmeigs mmeigs merged commit e29b8a8 into main Jul 12, 2024
4 checks passed
@mmeigs mmeigs deleted the DOP-4784-fix-404-chatbot branch July 12, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants