Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-4798: role files #28

Merged
merged 4 commits into from
Mar 28, 2019
Merged

DOCSP-4798: role files #28

merged 4 commits into from
Mar 28, 2019

Conversation

danielborowski
Copy link
Contributor

No description provided.

Copy link
Member

@sophstad sophstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes, mostly to make sure PropTypes is configured properly!

front-end/src/components/Roles/Code.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Program.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Program.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Link.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/GUILabel.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Ref.js Outdated Show resolved Hide resolved
front-end/tests/Role.test.js Show resolved Hide resolved
front-end/src/components/ComponentFactory.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Ref.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Ref.js Show resolved Hide resolved
front-end/src/components/Roles/GUILabel.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Program.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Ref.js Outdated Show resolved Hide resolved
front-end/src/components/Roles/Ref.js Outdated Show resolved Hide resolved
Copy link
Member

@sophstad sophstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@danielborowski danielborowski merged commit c2a8c30 into master Mar 28, 2019
@danielborowski danielborowski deleted the DOCSP-4798 branch March 28, 2019 19:55
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
* role files

* fixes to proptypes and some logic

* more tests for roles!

* test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants