fix: support update of description for project api key resource #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation and fixing role_names attribute in project assignments
AgustinBettati
changed the title
AgustinBettati
commented
Jul 28, 2023
| The following are valid roles: | ||
| * `GROUP_OWNER` | ||
| * `GROUP_READ_ONLY` | ||
| * `GROUP_DATA_ACCESS_ADMIN` | ||
| * `GROUP_DATA_ACCESS_READ_WRITE` | ||
| * `GROUP_DATA_ACCESS_READ_ONLY` | ||
| * `GROUP_CLUSTER_MANAGER` | ||
| * | ||
| ### Programmatic API Keys |
There was a problem hiding this comment.
This section is unrelated to project api key resource, seems like a copy paste that came from project resource documentation
AgustinBettati
commented
Jul 28, 2023
| Project Assignment attribute is optional (Use project_assignment going forward as role_names parameter above is deprecated) | ||
|
|
||
| * `project_id` - (Required) Project ID to assign to Access Key | ||
| * `role_names` - Name of the role. This resource returns all the roles the user has in Atlas. | ||
| * `role_names` - (Required) List of Project roles that the Programmatic API key needs to have. Ensure you provide: at least one role and ensure all roles are valid for the Project. You must specify an array even if you are only associating a single role with the Programmatic API key. |
There was a problem hiding this comment.
role_names is marked as required in our schema, and also verified that an empty array causes project assignment to not be created.
wtrocki
reviewed
Jul 28, 2023
wtrocki
approved these changes
Jul 28, 2023
andreaangiolillo
approved these changes
Jul 28, 2023
|
Hello @pierwill @zach-carr @jwilliams-mongo! I will be merging this PR, but feel free to review and if you have any comments I can address them in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: INTMDB-917
Updating description of an api key in the mongodbatlas_project_api_key resource was not contemplated in update. This includes a new request for handling this scenario.
Type of change:
Required Checklist:
Further comments