Accepting string numbers in limit, skip, maxScan and batchSize methods #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Nov 22, 2016
| * | ||
| * query.comment('feed query'); | ||
| */ | ||
|
|
||
| ;['limit', 'skip', 'maxScan', 'batchSize', 'comment'].forEach(function (method) { | ||
| Query.prototype[method] = function (v) { | ||
| if (method !== 'comment') { | ||
| let value = Number(v); |
There was a problem hiding this comment.
This lib still supports node 0.10 and 0.12, so can't use let or Number.isNaN.
There was a problem hiding this comment.
Great, i really didn't know it, by the way how i know which characteristics are available in what version of nodejs, for example, how i know that Number.isNaN isn't available in nodejs 0.12
There was a problem hiding this comment.
General idea is that node 0.10 and 0.12 don't support anything from ECMAScript 2015 / ES6, node 4 supports some, node 5 supports a little more, etc. TBH it's mostly just trial and error for me, just run node v0.10 and try using Number.isNan() :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.