Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight buttons when selected #1716

Closed
RayBB opened this issue Aug 19, 2018 · 4 comments · Fixed by #1866
Closed

Highlight buttons when selected #1716

RayBB opened this issue Aug 19, 2018 · 4 comments · Fixed by #1866

Comments

@RayBB
Copy link

RayBB commented Aug 19, 2018

Is your feature request related to a problem? Please describe.

  • I'm always frustrated when I'm tabbing through input fields but there's no highlighting to tell which button is currently selected.

Describe the solution you'd like
Add a css so it's clear which button is currently active/selected.

Example:
A good example of this is in Bootstrap where if you select a button and then hit tab you can see the difference between which button is selected and which isn't.

In this screenshot the primary button is clearly selected:
image

Github, which has very similar CSS to Monica has an active view that looks like this:
image

@RayBB
Copy link
Author

RayBB commented Aug 19, 2018

@asbiin

This could be resolved most easily by removing this one line:

outline: none;

However, I've also noticed that the style/colors for buttons is a bit wonky in general. For example:
the text color is blue for the green buttons when adding them. If you left click on add (keep holding) and drag away from being on the button the background color turns grey.
peek 2018-08-19 14-40

Github uses a framework called primer for styles.
If we wanted to take just the CSS from the buttons it lives here. Otherwise we can just take the parts that would fix these color issues.

@djaiss
Copy link
Member

djaiss commented Sep 10, 2018

Yes excellent idea. We need this indeed.

@RayBB
Copy link
Author

RayBB commented Sep 10, 2018

I would be happy to help with this but setting up the dev environment has proved to be more work than I expected. I tried following the instructions but not being familiar with the tooling I got stuck #1739 and simply don't have the time now to dig into what else I need to follow.

Some docs making it a bit easier for new contributes to get setup would be helpful.

@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants