feat: CardDAV support #1284

kidk · 2018-05-06T14:03:13Z

WIP for #582

This is what I have after spending a couple of hours on it, the basic UI of Sabre works, but the two clients I've tested give me errors.

Evolution because of a misconfiguration in the client, so it sends an empty request size. Ref
IOS 12 still unknown. I've reverted to doing own authentication, instead of using the Laravel system, but that hasn't resolved the issue. Next up is looking at the technical details.

There is still a lot of debug code in there, but I wanted to already share this to see if people have comments or requests. I've added a TODO below to give you an idea on the work that is still needed.

Adding more Contacts testing data
First working client (Evolution and IOS)
Read only CardDAV access
Add remaining fields

djaiss

Amazing. Really amazing. I could not have done this myself. Can't wait to see how it evolves.

djaiss · 2018-05-09T00:32:50Z

app/Http/Controllers/CardDAV/CardDAVController.php

+        \Debugbar::disable();
+
+        // TODO: Not sure if this is needed, check later
+        date_default_timezone_set('Europe/Berlin');


If anything, probably should be set to UTC?

djaiss · 2018-05-09T00:36:52Z

app/Http/Controllers/CardDAV/MonicaCardDAVBackend.php

+     * Returns the list of addressbooks for a specific user.
+     *
+     * Every addressbook should have the following properties:
+     *   id - an arbitrary unique id


Could we use our HashID here?

I will try, need to see if we can use non-numeric values.

djaiss · 2018-05-09T00:41:04Z

app/Http/Controllers/CardDAV/MonicaCardDAVBackend.php

+     * This method should work identical to getCard, but instead return all the
+     * cards in the list as an array.
+     *
+     * If the backend supports this, it may allow for some speed-ups.


Why wouldn't it?

djaiss · 2018-05-09T00:45:09Z

app/Http/Controllers/CardDAV/MonicaSabreBackend.php

+     */
+    function check(\Sabre\HTTP\RequestInterface $request, \Sabre\HTTP\ResponseInterface $response) {
+        Log::debug(__CLASS__.' check', func_get_args());
+        if (Auth::check() || Auth::attempt(['email' => $request->getRawServerValue('PHP_AUTH_USER'), 'password' => $request->getRawServerValue('PHP_AUTH_PW')])) {


Might be easier to put Auth::attempt(['email' => $request->getRawServerValue('PHP_AUTH_USER'), 'password' => $request->getRawServerValue('PHP_AUTH_PW')]) in a variable so this line is more readable.

I agree. I might revert back to using https://laravel.com/docs/5.6/authentication#stateless-http-basic-authentication I prefer using the framework systems whenever possible, but I need to figure out the issue with sync first.

kidk · 2018-05-11T18:32:08Z

It currently works for IOS and Evolution. This means the basic building blocks for CardDAV are in place and all that remains is polishing. This means adding other fields, data, and setting up the ReadOnly permissions.

djaiss · 2018-05-14T00:47:04Z

@kidk awesome! Let me know when you need a review!

cweagans · 2018-06-14T03:50:23Z

I'm super excited for this to land. Having a contacts database that's shared with my wife + a nice UI + a way to record extra notes and stuff is gonna be amazing.

sonarcloud

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 1

See all issues in SonarCloud

asbiin · 2018-10-28T09:41:07Z

Thank you so much @kidk for your help!!
I will merge this soon. I think we should improve this little by little instead of one big PR.
This is BETA feature, not enabled by default: you'll have to enable it with CARDDAV_ENABLED=true.
For now it's only readonly, which is very nice!

kidk · 2018-10-28T10:27:14Z

No problem, just glad to help on such an amazing project. Thanks for cleaning up the code.

I have some time the next couple of weeks to test and improve the code where needed. So feel free to tag me on any bugs or feature requests.

CHANGELOG

djaiss · 2018-10-28T12:09:26Z

app/Http/Controllers/CardDAVController.php

+        // Disable debugger for caldav output
+        Debugbar::disable();
+
+        // Initiate custom backends for link between Sabra and Monica


Suggested change

// Initiate custom backends for link between Sabra and Monica

// Initiate custom backends for link between Sabre and Monica

djaiss · 2018-10-28T12:16:42Z

app/Models/CardDAV/Backends/MonicaPrincipleBackend.php

+    }
+
+    /**
+     * Returns a specific principal, specified by it's path.


Suggested change

* Returns a specific principal, specified by it's path.

* Returns a specific principal, specified by its path.

djaiss · 2018-10-28T12:20:00Z

CHANGELOG

@@ -18,6 +18,7 @@ UNRELEASED CHANGES:
 * API breaking change: Remove 'PUT /contacts/:contact_id/pets/:id' in favor of 'PUT /pets/:id' with a 'contact_id'
 * API breaking change: Every validator fails now send a HTTP 400 code (was 200) with the error 32
 * API breaking change: Every Invald Parameters errors now send a HTTP 400 (was 500 or 200) code with the error 41
+* Add CardDAV support (readonly)


Suggested change

* Add CardDAV support (readonly)

* Add CardDAV support (readonly - disabled by default). To enable it, toggle the `CARDDAV_ENABLED` env variable.

dosch · 2019-05-13T09:21:53Z

I am unable to see the options to sync over CardDav. Is there already some documentation, or where can find this? Thnx!

asbiin · 2019-05-14T16:14:52Z

@dosch The feature is not yet available on app.monicahq.com, we have to validate it yet, but it will be activated soon.

asbiin · 2019-09-16T10:46:18Z

Hi folks! Carddav is now activated on all account on app.monicahq.com!
Let me now if it's working ... or not.

dosch · 2019-10-01T09:17:25Z

I (finally) added the Monica Carddav to my Contacts.app in MacOS.
But the contacts I already have in Monica do not appear in the Contacts.app and new contacts I add to the app do not appear in Monica.

Am I missing something?

github-actions · 2021-01-14T00:47:33Z

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

kidk added 3 commits May 3, 2018 16:32

WIP CalDAV / CardDAV

13fa855

Basic routing in place

f29e581

[WIP] Basic auth working and addressbooks, still lots of work todo

7052010

djaiss reviewed May 9, 2018

View reviewed changes

kidk added 5 commits May 11, 2018 18:47

Fixed incorrect basePath for Sabre and removed sync plugin

5e4b52b

Replaced custom auth backend with Sabre one

62ef577

Replaced userId with email everywhere

d530be7

Changed default timezone to UTC

6cfec8b

Working on IOS and Evolution

34f8d04

kidk added 8 commits May 11, 2018 22:44

WIP CalDAV / CardDAV

5edeee1

Basic routing in place

fafa264

[WIP] Basic auth working and addressbooks, still lots of work todo

5082eac

Fixed incorrect basePath for Sabre and removed sync plugin

533f573

Replaced custom auth backend with Sabre one

757a102

Replaced userId with email everywhere

111a5fb

Changed default timezone to UTC

8fbad53

Working on IOS and Evolution

ec87b13

kidk force-pushed the feature/sync branch from 34f8d04 to ec87b13 Compare May 11, 2018 20:45

Merge branch 'feature/sync' of github.com:kidk/monica into feature/sync

0942a4c

kidk mentioned this pull request May 15, 2018

FakeContentTableSeeder now adds meaningfull data in ContactFields #1340

Merged

kidk force-pushed the feature/sync branch from 659d058 to 0942a4c Compare May 20, 2018 12:28

kidk added 2 commits May 27, 2018 15:23

Merge branch 'master' into feature/sync

f5047fd

Added Name, Picture, Gender and Contactfields to VCard

6e5feed

kidk added 4 commits June 15, 2018 21:05

Added birthday

62453b2

Merge remote-tracking branch 'upstream/master' into feature/sync

4c534e8

Reformatted directory structure

730a876

Add browser view in debug mode

a6289d8

sonarcloud bot reviewed Oct 27, 2018

View reviewed changes

asbiin added 5 commits October 28, 2018 09:36

fix

5469d73

Merge remote-tracking branch 'origin/master' into feature/sync

5ce3b92

Rename auth class

eaedeb3

update changelog

71a7474

fix styleci

8ca6300

asbiin changed the title ~~[WIP] CalDAV / CardDAV~~ feat: CardDAV support Oct 28, 2018

djaiss reviewed Oct 28, 2018

View reviewed changes

CHANGELOG Outdated Show resolved Hide resolved

djaiss reviewed Oct 28, 2018

View reviewed changes

asbiin added 11 commits October 28, 2018 14:10

Add some tests

ed7e8b0

fixes suggested by @djaiss

48d8cb9

Fix styleci

bbc06f5

update

ce6f47e

fix

09b48aa

Merge remote-tracking branch 'origin/master' into feature/sync

ddc05d5

skip test for now

016c6ea

Merge remote-tracking branch 'origin/master' into feature/sync

f1cf7bb

skip tests

c76f84a

Definitly skipping these *$!:^ tests

52931d4

damn

6b4ac19

asbiin merged commit c7eea2b into monicahq:master Oct 29, 2018

pqhf5kd mentioned this pull request Jan 12, 2019

Sync with CardDAV #582

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: CardDAV support #1284

feat: CardDAV support #1284

kidk commented May 6, 2018 •

edited

Loading

djaiss left a comment

djaiss May 9, 2018

kidk May 9, 2018

djaiss May 9, 2018

kidk May 9, 2018

djaiss May 9, 2018

djaiss May 9, 2018

kidk May 9, 2018

kidk commented May 11, 2018

djaiss commented May 14, 2018

cweagans commented Jun 14, 2018

sonarcloud bot left a comment

asbiin commented Oct 28, 2018

kidk commented Oct 28, 2018

djaiss Oct 28, 2018

djaiss Oct 28, 2018

djaiss Oct 28, 2018

dosch commented May 13, 2019

asbiin commented May 14, 2019

asbiin commented Sep 16, 2019

dosch commented Oct 1, 2019 •

edited

Loading

github-actions bot commented Jan 14, 2021

	// Initiate custom backends for link between Sabra and Monica
	// Initiate custom backends for link between Sabre and Monica

	* Returns a specific principal, specified by it's path.
	* Returns a specific principal, specified by its path.

	* Add CardDAV support (readonly)
	* Add CardDAV support (readonly - disabled by default). To enable it, toggle the `CARDDAV_ENABLED` env variable.

feat: CardDAV support #1284

feat: CardDAV support #1284

Conversation

kidk commented May 6, 2018 • edited Loading

djaiss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kidk commented May 11, 2018

djaiss commented May 14, 2018

cweagans commented Jun 14, 2018

sonarcloud bot left a comment

Choose a reason for hiding this comment

asbiin commented Oct 28, 2018

kidk commented Oct 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dosch commented May 13, 2019

asbiin commented May 14, 2019

asbiin commented Sep 16, 2019

dosch commented Oct 1, 2019 • edited Loading

github-actions bot commented Jan 14, 2021

kidk commented May 6, 2018 •

edited

Loading

dosch commented Oct 1, 2019 •

edited

Loading