feat: set currency and timezone for new users #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbiin
changed the title
…a into feat/set-default-currency
|
What's the goal of this PR? |
|
Default currency is USD, and default timezone is UTC for everyone. We can set these settings by detecting the current location of the user. |
djaiss
requested changes
Aug 20, 2018
app/Helpers/CountriesHelper.php
Outdated
| @@ -59,4 +64,118 @@ private static function getCommonNameLocale($country) | |||
| array_get($country, 'name.common', '') | |||
| ); | |||
| } | |||
|
|
|||
| private static function getCountry($iso) | |||
There was a problem hiding this comment.
Could you provide a description of what the method does?
app/Helpers/CountriesHelper.php
Outdated
| return $country; | ||
| } | ||
|
|
||
| public static function getDefaultCountryFromLang($locale) |
There was a problem hiding this comment.
Description (BlockDoc)?
Should it be named FromLocale instead?
app/Models/User/User.php
Outdated
| if (is_null($country)) { | ||
| $user->timezone = config('app.timezone'); | ||
| } else { | ||
| foreach ($country->currencies as $currencie) { |
…a into feat/set-default-currency
…a into feat/set-default-currency
![sonarcloud[bot]](https://avatars.githubusercontent.com/in/12526?s=60&v=4){kind=small}
asbiin
changed the title
asbiin
changed the title
asbiin
changed the title
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set currency and timezone for a new User, depending of its current connected country timezone, or locale.