Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language): support Arabic language and fix a lot of rtl displays #1736

Merged
merged 13 commits into from
Aug 25, 2018
Merged

feat(language): support Arabic language and fix a lot of rtl displays #1736

merged 13 commits into from
Aug 25, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Aug 22, 2018

Fix #1727

sonarcloud[bot]
sonarcloud bot reviewed Aug 22, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 34

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  2. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  3. Code Smell Code Smell: Expected selector ".people-show .pagehead .people-profile-information .tags li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  4. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  5. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  6. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  7. Code Smell Code Smell: Expected selector ".people-show .profile .work li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  8. Code Smell Code Smell: Expected selector ".people-show .profile .work li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  9. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  10. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  11. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  12. Code Smell Code Smell: Expected selector ".people-show .debts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  13. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  14. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  15. Code Smell Code Smell: Expected selector ".people-show .reminders .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  16. Code Smell Code Smell: Expected selector ".people-show .debts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  17. Code Smell Code Smell: Expected selector ".people-show .calls .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  18. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  19. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .tags li" (more)
  20. Code Smell Code Smell: Expected selector ".people-show .profile .people-list li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  21. Code Smell Code Smell: Expected selector ".people-show .profile .people-list li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  22. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  23. Code Smell Code Smell: Expected selector ".people-show .pagehead .people-profile-information .tags.rtl li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  24. Code Smell Code Smell: Expected selector ".people-show .profile .work li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  25. Code Smell Code Smell: Expected selector ".people-show .profile .work li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  26. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  27. Code Smell Code Smell: Expected selector ".people-show .calls .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  28. Code Smell Code Smell: Expected selector ".people-show .reminders .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  29. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  30. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .tags.rtl li" (more)
  31. Code Smell Code Smell: Expected selector ".people-show .activities .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  32. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  33. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)

See all issues in SonarCloud

@asbiin asbiin changed the title Support Arabic language and fix a lot of ltr displays Support Arabic language and fix a lot of rtl displays Aug 22, 2018
sonarcloud[bot]
sonarcloud bot reviewed Aug 23, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 34

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Expected selector ".people-show .debts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  2. Code Smell Code Smell: Expected selector ".people-show .reminders .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  3. Code Smell Code Smell: Expected selector ".people-show .activities .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  4. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  5. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  6. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  7. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  8. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .tags.rtl li" (more)
  9. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  10. Code Smell Code Smell: Expected selector ".people-show .calls .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  11. Code Smell Code Smell: Expected selector ".people-show .reminders .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  12. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  13. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary li" (more)
  14. Code Smell Code Smell: Expected selector ".people-show .calls .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  15. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  16. Code Smell Code Smell: Expected selector ".people-show .debts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  17. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  18. Code Smell Code Smell: Expected selector ".people-show .pagehead .people-profile-information .tags.rtl li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)

See all issues in SonarCloud

sonarcloud[bot]
sonarcloud bot reviewed Aug 23, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 34

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Expected selector ".people-show .reminders .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  2. Code Smell Code Smell: Expected selector ".people-show .profile .work li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  3. Code Smell Code Smell: Expected selector ".people-show .profile .work li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  4. Code Smell Code Smell: Expected selector ".people-show .profile .work li:last-child" to come before selector ".people-show .pagehead .people-profile-information .tags.rtl li" (more)
  5. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary li" (more)
  6. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  7. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  8. Code Smell Code Smell: Expected selector ".people-show .profile .work li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary li:not(:last-child)" (more)
  9. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .tags.rtl li" (more)
  10. Code Smell Code Smell: Expected selector ".people-show .calls .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  11. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  12. Code Smell Code Smell: Expected selector ".people-show .pagehead .people-profile-information .tags.rtl li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  13. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  14. Code Smell Code Smell: Expected selector ".people-show .debts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  15. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-actions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  16. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  17. Code Smell Code Smell: Expected selector ".people-show .debts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  18. Code Smell Code Smell: Expected selector ".people-show .profile .people-list li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  19. Code Smell Code Smell: Expected selector ".people-show .profile .work li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  20. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  21. Code Smell Code Smell: Expected selector ".people-show .calls .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  22. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  23. Code Smell Code Smell: Expected selector ".people-show .profile .people-list li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  24. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  25. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  26. Code Smell Code Smell: Expected selector ".people-show .gifts .gift-list-item-date li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  27. Code Smell Code Smell: Expected selector ".people-show .gifts .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  28. Code Smell Code Smell: Expected selector ".people-show .profile .introductions li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  29. Code Smell Code Smell: Expected selector ".people-show .tasks .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  30. Code Smell Code Smell: Expected selector ".people-show .profile .work li:last-child" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  31. Code Smell Code Smell: Expected selector ".people-show .activities .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li:not(:last-child)" (more)
  32. Code Smell Code Smell: Expected selector ".people-show .profile .people-information li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)
  33. Code Smell Code Smell: Expected selector ".people-show .reminders .pa2 li" to come before selector ".people-show .pagehead .people-profile-information .profile-detail-summary.rtl li" (more)

See all issues in SonarCloud

@asbiin asbiin changed the title Support Arabic language and fix a lot of rtl displays feat(language): support Arabic language and fix a lot of rtl displays Aug 23, 2018
@asbiin asbiin merged commit f34fff5 into master Aug 25, 2018
@asbiin asbiin deleted the i18n/add-arabic-language branch August 25, 2018 08:42
@asbiin asbiin mentioned this pull request Aug 26, 2018
Merged
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonarcloud sonarcloud[bot] sonarcloud[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arabic Support
1 participant
@asbiin