Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: life events #1765

Merged
merged 96 commits into from
Sep 25, 2018
Merged

feat: life events #1765

merged 96 commits into from
Sep 25, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Sep 1, 2018

This PR adds support for life events and will close #1762.

This is a huge feature, hence the big number of files changes.

This is the first version of the feature. All events that you create have the same structure: a date, a title and a description.

The second version of the feature will allow us to customize almost each event with specific metadata. For instance, the event studied abroad will let us define which country the contact will be in, as well as a date for the future return of the student, and will let us define a reminder for this date. The current PR has been created with this structure in mind.

Checklist

  • Add migrated = 1 to default columns that have been migrated
  • Add graduated as an event life type (icon)
  • Add the fact that we can associate someone from the contact's family to the life event instead of the contact himself
  • Fix editing a contact doesn't work anymore due to the change of getYears() method that I've changed

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.
  • If API is impacted, maintain the API's documentation.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 7

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Remove the unused function parameter "$request". (more)
  2. Code Smell Code Smell: Expected selector ".avatar-photo img" to come before selector ".life-event .life-event-add-icon img" (more)
  3. Code Smell Code Smell: Remove the unused function parameter "$request". (more)
  4. Code Smell Code Smell: Remove the unused function parameter "$request". (more)

See all issues in SonarCloud

@djaiss djaiss changed the title feat: life events [wip] feat: life events Sep 22, 2018
@djaiss djaiss merged commit e3e9fcb into master Sep 25, 2018
@djaiss djaiss deleted the 2018-08-30-life-events branch September 26, 2018 02:11
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to track life events
3 participants