-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: life events #1765
feat: life events #1765
Conversation
…nto 2018-08-30-life-events
…nto 2018-08-30-life-events
…nto 2018-08-30-life-events
…nto 2018-08-30-life-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 7
Including the following issue(s) which could not be reported in line:
- Code Smell: Remove the unused function parameter "$request". (more)
- Code Smell: Expected selector ".avatar-photo img" to come before selector ".life-event .life-event-add-icon img" (more)
- Code Smell: Remove the unused function parameter "$request". (more)
- Code Smell: Remove the unused function parameter "$request". (more)
…nto 2018-08-30-life-events
This pull request has been automatically locked since there |
This PR adds support for life events and will close #1762.
This is a huge feature, hence the big number of files changes.
This is the first version of the feature. All events that you create have the same structure: a date, a title and a description.
The second version of the feature will allow us to customize almost each event with specific metadata. For instance, the event
studied abroad
will let us define which country the contact will be in, as well as a date for the future return of the student, and will let us define a reminder for this date. The current PR has been created with this structure in mind.Checklist
migrated = 1
to default columns that have been migratedgraduated
as an event life type (icon)Code-related tasks
If the code changes the SQL schema
vCard
and.csv
files.Other tasks
UNRELEASED
.