-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse FN property when import vcards #1797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 3
Including the following issue(s) which could not be reported in line:
- Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 3
Including the following issue(s) which could not be reported in line:
- Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 3
Including the following issue(s) which could not be reported in line:
- Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)
Thanks so much for your help @fabwu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 3
Including the following issue(s) which could not be reported in line:
- Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)
@fabwu |
@asbiin here the job on Jenkins seems stuck. Do you see how to unstuck this? |
This pull request has been automatically locked since there |
Fixes #1796