Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse FN property when import vcards #1797

Merged
merged 16 commits into from
Oct 27, 2018
Merged

Conversation

fabwu
Copy link

@fabwu fabwu commented Sep 8, 2018

Fixes #1796

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)

See all issues in SonarCloud

@djaiss
Copy link
Member

djaiss commented Sep 24, 2018

Thanks so much for your help @fabwu
I'll review this PR in the coming days, sorry for the time it takes to do so.

@djaiss djaiss self-assigned this Sep 24, 2018
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Class "ImportJob" has 35 methods, which is greater than 30 authorized. Split it into smaller classes. (more)

See all issues in SonarCloud

@djaiss
Copy link
Member

djaiss commented Oct 9, 2018

@fabwu
Thanks so much for your work.
if you could just fix the two issues reported by Sonar, we'd be good to go!

@djaiss
Copy link
Member

djaiss commented Oct 22, 2018

@asbiin here the job on Jenkins seems stuck. Do you see how to unstuck this?

@djaiss djaiss merged commit 3da9e92 into monicahq:master Oct 27, 2018
@fabwu fabwu deleted the add-fn-tag branch October 28, 2018 14:35
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vCard import doesn't support FN tag
2 participants