Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix life event 'got a new vehicle' misspell #1875

Merged
merged 11 commits into from
Oct 9, 2018
Merged

fix: fix life event 'got a new vehicle' misspell #1875

merged 11 commits into from
Oct 9, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Oct 4, 2018

No description provided.

@djaiss
Copy link
Member

djaiss commented Oct 4, 2018

@asbiin good, but we also need to change the life_event_types table and update the default_life_event_type_key field that takes the updated translation_key.

@asbiin
Copy link
Member Author

asbiin commented Oct 9, 2018

Need to rename the svg file too.

@asbiin asbiin merged commit 0360018 into master Oct 9, 2018
@asbiin asbiin deleted the fix/vehicle branch October 9, 2018 20:05
@asbiin asbiin mentioned this pull request Oct 18, 2018
Closed
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asbiin @djaiss @MonicaBot