Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): improve text when adding contact, not just "significant other" #1881

Merged
merged 6 commits into from
Oct 25, 2018

Conversation

Flimm
Copy link

@Flimm Flimm commented Oct 7, 2018

The contact could be another family member.

The contact could be another family member, not just a significant
other.
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@asbiin asbiin changed the title Improve text when adding contact, not just "significant other" fix(i18n): improve text when adding contact, not just "significant other" Oct 7, 2018
@asbiin
Copy link
Member

asbiin commented Oct 10, 2018

@djaiss it needs to run php artisan lang:generate and yarn run production before merge.

@asbiin asbiin merged commit 243d315 into monicahq:master Oct 25, 2018
@asbiin
Copy link
Member

asbiin commented Oct 25, 2018

Thanks @Flimm !

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants