fix: aws server endpoint configuration handling #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the default case (where AWS_SERVER is unset and/or empty) set the value of the endpoint to null. Note that the underlying S3Client ignores args in the parameter array that are null, because it calls 'isset' on them.
|
|
|
Nice work, thank you for your help @allanlw ! I had removed the 'endpoint' value, because I though it was useless, but it wasn't ... |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #1966 by correctly handling the AWS_SERVER environment variable that is outlined in the .env.example
I tested this manually in the following cases:
In all four cases, uploading and viewing avatars works as expected, so I think it's unlikely that this will cause any breakage.