Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include apache.conf example for ssl configuration #2047

Merged
merged 4 commits into from
Nov 18, 2018
Merged

docs: include apache.conf example for ssl configuration #2047

merged 4 commits into from
Nov 18, 2018

Conversation

DanTulovsky
Copy link

Add an apache example for the ssl config.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2018

CLA assistant check
All committers have signed the CLA.

@DanTulovsky DanTulovsky changed the title doc: include apache.conf example for ssl configuration docs: include apache.conf example for ssl configuration Nov 14, 2018
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great idea!
I've added some comments based on the apache file I'm using.

docs/installation/ssl.md Show resolved Hide resolved
docs/installation/ssl.md Show resolved Hide resolved
docs/installation/ssl.md Show resolved Hide resolved
@DanTulovsky
Copy link
Author

(Sorry, my first time submitting on github...) It says one of the checks isn't finished, but details shows an error (https://jenkins.asbin.net/job/MonicaHq/job/monica/job/PR-2047/3/display/redirect):

HTTP ERROR 404
Problem accessing /job/MonicaHq/job/monica/job/PR-2047/3/display/redirect. Reason:

Not Found

This prevents a submit?

@asbiin
Copy link
Member

asbiin commented Nov 15, 2018

@DanTulovsky No there is no problem with this, we'll handle it.

@asbiin asbiin merged commit 3a4e135 into monicahq:master Nov 18, 2018
@asbiin
Copy link
Member

asbiin commented Nov 18, 2018

Thank you very much @DanTulovsky

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants