Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix relationship destroy route use #2051

Merged
merged 3 commits into from
Nov 14, 2018
Merged

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Nov 14, 2018

Relationships destroy did'nt use the right route (it was the route for 'update')

@asbiin asbiin changed the title Fix/update conversation fix: fix update conversation route Nov 14, 2018
@asbiin asbiin changed the title fix: fix update conversation route fix: fix update relationships route Nov 14, 2018
@asbiin asbiin changed the title fix: fix update relationships route fix: fix relationship destroy route use Nov 14, 2018
@asbiin asbiin merged commit 18a97d3 into master Nov 14, 2018
@asbiin asbiin deleted the fix/update-conversation branch November 14, 2018 22:28
@djaiss
Copy link
Member

djaiss commented Dec 1, 2018

But... it WAS to update the relationship, not destroy it.
Now, editing a relationship ALWAYS deletes the contact, lol. I'll fix it.

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants