Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change contact list class to allow following link #2124

Merged
merged 3 commits into from
Dec 6, 2018

Conversation

mccollam
Copy link

@mccollam mccollam commented Dec 3, 2018

This changes the class of the contact list ul element on the modal activity view to allow clicking names to work as intended (closes #2048).

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mccollam ! See my review here

resources/views/people/modal/activity_view.blade.php Outdated Show resolved Hide resolved
@asbiin asbiin added the reviewed label Dec 4, 2018
@asbiin asbiin merged commit 09b0d70 into monicahq:master Dec 6, 2018
@asbiin
Copy link
Member

asbiin commented Dec 6, 2018

Thank you @mccollam!

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View activity window does not permit clicking through to other people involved
2 participants