Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow editing of phone calls #2134

Merged
merged 17 commits into from
Dec 8, 2018
Merged

feat: allow editing of phone calls #2134

merged 17 commits into from
Dec 8, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 5, 2018 •
edited
Loading

This PR allows the editing of phone calls. This close #799

  • I also rewrote all the phone calls methods using Services, therefore cleaning the existing codebase.
  • I rewrote the API methods to make them compatible with the new Services.
  • I fixed all the tests that were incomplete.

@djaiss djaiss mentioned this pull request Dec 5, 2018
Closed
@djaiss djaiss changed the title feat: allow editing of phone calls [wip] feat: allow editing of phone calls Dec 8, 2018
@djaiss djaiss merged commit 6f76405 into master Dec 8, 2018
@djaiss djaiss deleted the 2018-12-04-allow-phone-call-editing branch December 19, 2018 00:26
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support editing phone call logs
2 participants
@djaiss @MonicaBot