-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add foundation to support emotions and ability to log emotions during a phone call #2144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw some relevant strings pop up in Crowdin, but not all emotions. @djaiss Can users tag primary, secondary and tertiary emotions, or only (a) particular group(s)? And shouldn't these emotions be translated also? Would be interesting to see if they are translated already in academic literature. EDIT: what I saw show up, was in 'people.php' and this is a different thing (and this is an old development, actually). I don't remember from the top of my head, but I guess emotions have been translated (or made available for translations) already some time ago (?) |
This pull request has been automatically locked since there |
This PR adds the foundation for supporting emotions throughout the platform. That means we'll be able to use emotions to describe how someone/something made us feel.
I've created an object
Emotion
to represent this. An emotion is universal and therefore not customizable through the Settings, nor does it belong to an Account.For instance you could add emotions to a phone call, representing that it made you feel happy and discouraged at the same time.
Later on, we would be able to have interesting data, like how many times you are happy after a call, or who makes you happy the most, etc...
The list of emotions is based on http://changingminds.org/explanations/emotions/basic%20emotions.htm
and comes precisely from
Shaver, P., Schwartz, J., Kirson, D., & O'Connor, C. (2001). Emotional Knowledge: Further Exploration of a Prototype Approach. In G. Parrott (Eds.), Emotions in Social Psychology: Essential Readings (pp. 26-56). Philadelphia, PA: Psychology Press.
As a proof of concept, this PR also adds the ability to add emotions when you log a call.