Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add foundation to support emotions and ability to log emotions during a phone call #2144

Merged
merged 28 commits into from
Dec 13, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 9, 2018

This PR adds the foundation for supporting emotions throughout the platform. That means we'll be able to use emotions to describe how someone/something made us feel.

I've created an object Emotion to represent this. An emotion is universal and therefore not customizable through the Settings, nor does it belong to an Account.

For instance you could add emotions to a phone call, representing that it made you feel happy and discouraged at the same time.

Later on, we would be able to have interesting data, like how many times you are happy after a call, or who makes you happy the most, etc...

The list of emotions is based on http://changingminds.org/explanations/emotions/basic%20emotions.htm

and comes precisely from

Shaver, P., Schwartz, J., Kirson, D., & O'Connor, C. (2001). Emotional Knowledge: Further Exploration of a Prototype Approach. In G. Parrott (Eds.), Emotions in Social Psychology: Essential Readings (pp. 26-56). Philadelphia, PA: Psychology Press.

image

As a proof of concept, this PR also adds the ability to add emotions when you log a call.

@djaiss djaiss changed the title feat: add basic support for emotions feat: add basic support for emotions [wip] Dec 9, 2018
@djaiss djaiss changed the title feat: add basic support for emotions [wip] feat: add foundation to support emotions [wip] Dec 9, 2018
@djaiss
Copy link
Member Author

djaiss commented Dec 11, 2018

This is what it currently looks like to log emotions for a phone call.

image

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 2

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 2

See all issues in SonarCloud

@djaiss djaiss changed the title feat: add foundation to support emotions [wip] feat: add foundation to support emotions and ability to log emotions during a phone call Dec 13, 2018
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

See all issues in SonarCloud

@djaiss djaiss merged commit a4e051e into master Dec 13, 2018
@djaiss djaiss deleted the 2018-12-08-emotions branch December 19, 2018 00:26
@keunes
Copy link

keunes commented Dec 17, 2019

I saw some relevant strings pop up in Crowdin, but not all emotions. @djaiss Can users tag primary, secondary and tertiary emotions, or only (a) particular group(s)? And shouldn't these emotions be translated also? Would be interesting to see if they are translated already in academic literature.

EDIT: what I saw show up, was in 'people.php' and this is a different thing (and this is an old development, actually). I don't remember from the top of my head, but I guess emotions have been translated (or made available for translations) already some time ago (?)

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants