Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate akka-connector #50

Closed
paualarco opened this issue May 19, 2020 · 7 comments
Closed

Deprecate akka-connector #50

paualarco opened this issue May 19, 2020 · 7 comments

Comments

@paualarco
Copy link
Member

Maybe rename akka connector for reactive streams or just create new ones for ZIO and FS2.

@t1707
Copy link
Collaborator

t1707 commented Jun 30, 2020

+1 for just create new ones for ZIO and FS2.

@paualarco
Copy link
Member Author

Yeah that sounds good

@paualarco
Copy link
Member Author

paualarco commented Jul 2, 2020

@Avasil guess ZIO conversion are better covered by monix-bio

@Avasil
Copy link
Contributor

Avasil commented Jul 2, 2020

What do you have in mind as this connector/module?

A while ago I wrote https://monix.io/docs/3x/reactive/observable.html#interoperability-with-other-streams-api-akka-streams-fs2 (ZIO Streams didn't exist at the time)

I feel like a doc could be good enough unless you want to wrap API

@paualarco
Copy link
Member Author

@Avasil I guess yeah its a wrapper but still can reduce some boilerplate code and make it more idiomatic, since monix provide generic reactive streams interoperability but not specific to the library.

For example the Monix documentation only shows how to convert an akka Source to Observable, but the monix-akka conector makes it easier for the user to perform such conversion and also provides conversions from Sink to Consumer and viceversa just by typing .asSink, asSource or asConsumer, asObservable.

I was just contemplating to do something similar for Fs2 and Zio to provide something like observable.asZStream and consumer.asZSink.

@paualarco paualarco changed the title Add reactive streams interoperability Deprecate akka-connector Mar 14, 2021
@paualarco
Copy link
Member Author

paualarco commented Mar 14, 2021

I agree with @Avasil and think that the better thing is to just provide docs on how to convert to different Reactive streams implementations, Akka is in monix.io maybe it could include a complete with also FS2, ZIO, Reactor... Although the concept is much of the same. This will also avoid cross dependency management on the user side.
So, will be deprecating the akka-connector in the next releases if no one opposes :)

@Avasil
Copy link
Contributor

Avasil commented Mar 15, 2021

Yup, I still think docs are good enough 👍
They just need an update/be more visible

I'm planning an overhaul but with my pace it's going to be 2025 🙈

paualarco added a commit to paualarco/monix-connect that referenced this issue Apr 7, 2021
paualarco added a commit to paualarco/monix-connect that referenced this issue Apr 7, 2021
paualarco added a commit to paualarco/monix-connect that referenced this issue Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants