fix(typing): pinyin input (hakujitsu) #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakujitsu
force-pushed
the
add-support-for-pinyin-typing
branch
from
e3a44c2
to
4f8c255
Compare
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/4880841373 |
|
Im gonna convert it to draft while you test everything |
Miodec
added
the
waiting for update
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
Any update? @hakujitsu |
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
@hakujitsu have you had a chance to test this? |
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
This PR is stale. Please trigger a re-run of the PR check action. |
Miodec
changed the title
Miodec
approved these changes
Nov 3, 2023
|
Tested by Discord server members |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for Pinyin typing (closes #4230)
handleCharbefore ending the test (since Chinese input can result in multiple characters being added (re_dai_yu_lin -> 熱帶雨林)Untitled.2.mov
Testing
Conducted some manual testing using both pinyin input method and handwriting input method.
If anyone could do additional testing using other input methods (e.g. Cangjie and Wubi), that would be most appreciated, as I am unfamiliar with how to use them.