Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): pinyin input (hakujitsu) #4256

Merged

Conversation

hakujitsu
Copy link
Contributor

Description

Added support for Pinyin typing (closes #4230)

  • Ignored spaces when typing Chinese and composition has not ended
  • Added additional check to ensure all characters are parsed by handleChar before ending the test (since Chinese input can result in multiple characters being added (re_dai_yu_lin -> 熱帶雨林)
  • Added an additional check when the number of characters decreases to handle the conversion of pinyin to Chinese characters
Untitled.2.mov

Testing

Conducted some manual testing using both pinyin input method and handwriting input method.

If anyone could do additional testing using other input methods (e.g. Cangjie and Wubi), that would be most appreciated, as I am unfamiliar with how to use them.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 4, 2023
@hakujitsu hakujitsu force-pushed the add-support-for-pinyin-typing branch from e3a44c2 to 4f8c255 Compare May 4, 2023 08:49
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/4880841373

@Miodec Miodec marked this pull request as draft May 5, 2023 11:19
@Miodec
Copy link
Member

Miodec commented May 5, 2023

Im gonna convert it to draft while you test everything

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 9, 2023
@github-actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label May 16, 2023
@github-actions github-actions bot closed this May 23, 2023
@Miodec Miodec reopened this May 24, 2023
@Miodec
Copy link
Member

Miodec commented May 24, 2023

Any update? @hakujitsu

@github-actions github-actions bot removed the Stale Has not been updated in a while label May 24, 2023
@github-actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label May 31, 2023
@github-actions github-actions bot closed this Jun 8, 2023
@Miodec Miodec reopened this Jun 12, 2023
@Miodec
Copy link
Member

Miodec commented Jun 12, 2023

@hakujitsu have you had a chance to test this?

@github-actions github-actions bot removed the Stale Has not been updated in a while label Jun 12, 2023
@github-actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Jun 20, 2023
@github-actions github-actions bot closed this Jun 28, 2023
@Miodec Miodec reopened this Jun 28, 2023
@github-actions github-actions bot removed the Stale Has not been updated in a while label Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Jul 7, 2023
@github-actions github-actions bot closed this Jul 15, 2023
@Miodec Miodec reopened this Jul 17, 2023
@github-actions github-actions bot removed the Stale Has not been updated in a while label Jul 17, 2023
@github-actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Jul 25, 2023
@github-actions github-actions bot closed this Aug 1, 2023
@Miodec Miodec reopened this Nov 3, 2023
@Miodec Miodec changed the title Add support for pinyin typing fix(typing): pinyin input (hakujitsu) Nov 3, 2023
@Miodec Miodec marked this pull request as ready for review November 3, 2023 14:23
@Miodec
Copy link
Member

Miodec commented Nov 3, 2023

Tested by Discord server members

@Miodec Miodec merged commit 6daaabb into monkeytypegame:master Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff Stale Has not been updated in a while waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not type traditional Chinese
3 participants