Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misaligned tooltip at the bottom of the privacy policy (Sanjeet4567) #5446

Closed

Conversation

Sanjeet4567
Copy link

Description

Earlier :When hovering over the tooltip, it is center aligned away from the the text being hovered over.
Screenshot from 2024-05-26 11-07-43

After fix:The tooltip appears right above Miodec's username.
Screenshot from 2024-05-26 11-06-38

Checks

Closes #5443

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 26, 2024
@Sanjeet4567 Sanjeet4567 changed the title fix:Misaligned tooltip at the bottom of the privacy policy (Sanjeet4567) fix: Misaligned tooltip at the bottom of the privacy policy (Sanjeet4567) May 26, 2024
@unrealapex
Copy link
Contributor

I think having the text as Discord: @miodec would be more consistent with the formatting above.

@@ -435,7 +435,7 @@ <h1 id="Contact_Info">How to contact us</h1>
Discord:
<span
aria-label="Click To Copy"
data-balloon-pos="up"
data-balloon-pos="up-left"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extoplasm brought up that this change does not center the tooltip. See their feedback.

@Sanjeet4567
Copy link
Author

I have made the asked changes .Kindly review.
After:
Screenshot from 2024-05-28 14-34-55

@Miodec
Copy link
Member

Miodec commented May 28, 2024

Heres the actual fix: 898278b

Thank you for your PR though.

@Miodec Miodec closed this May 28, 2024
@Miodec
Copy link
Member

Miodec commented May 28, 2024

I have made the asked changes .Kindly review. After: Screenshot from 2024-05-28 14-34-55

Haha, looks like we made the same change at the same time :D

@Sanjeet4567
Copy link
Author

Haha, looks like we made the same change at the same time :D

yeah ,No problem ,maybe next time I will be quick and better : ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned tooltip at the bottom of the privacy policy
4 participants