Implemented basic XmlImporter functionality #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
tomspilman
added a commit
that referenced
this pull request
Apr 23, 2014
Implemented basic XmlImporter functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers much of the basic XmlImporter functionality. It supports reading from XML into any custom data type it can find in loaded assemblies. It supports all the integral types, generic collections, and the efficient array format for integers, vectors. It also handles polymorphic types and explicit type specifications for elements.
Also included are XML test data and corresponding classes I've been using to debug it. They're straight out of Sean Hargreaves' Everything you ever wanted to know about IntermediateSerializer. No unit tests yet, but it's a step towards it.
Stuff I haven't implemented yet:
Nothing too tough to do, I just ran out of time for now. Later passes can finish off these features. Additionally, if someone needs the IntermediateSerializer, they can refactor this code and create the writing end of it pretty easily.
Note that MonoGame doesn't currently have a ReflectiveWriter so AFAIK custom types will need a ContentTypeWriter defined.