Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SKXamlCanvas on Uno Platform SkiaSharp backends v2.0 (#1634) #1704

Merged
merged 44 commits into from
Jun 11, 2021

Conversation

mattleibow
Copy link
Contributor

Description of Change

Getting better builds for #1634

jeromelaban and others added 30 commits May 13, 2021 10:24
…ckends

This enables SKXamlCanvas for Uno Platform's support for for GTK (Linux, Windows, macOS), WPF and Tizen, for Uno 3.6 and later.
# Conflicts:
#	samples/Basic/Uno/SkiaSharpSample.Android/SkiaSharpSample.Android.csproj
#	samples/Gallery/Uno/SkiaSharpSample.Wasm/SkiaSharpSample.Wasm.csproj
# Conflicts:
#	source/SkiaSharpSource.Linux.sln
#	source/SkiaSharpSource.Mac.sln
@jeromelaban
Copy link
Contributor

@mattleibow I've published a new build of Uno, 3.7.6 which will fix the invalid dependency you've seen. I've made the changes in a commit from your branch here: unoplatform@c9563e5, if you want to cherry pick :)

@mattleibow
Copy link
Contributor Author

Awesome, starting the build again. Hopefully this is the one!

@jeromelaban
Copy link
Contributor

Close, I guess ;) Let me know how I can help!

@jeromelaban
Copy link
Contributor

Woohoo ✅✅✅✅ ;)

@mattleibow mattleibow changed the title [WIP] Building for #1634 Add support for SKXamlCanvas on Uno Platform SkiaSharp backends v2.0 (#1634) Jun 3, 2021
This reverts commit 289052e.
This reverts commit 28b0ee8.
@mattleibow mattleibow marked this pull request as ready for review June 11, 2021 02:01
@mattleibow mattleibow closed this Jun 11, 2021
@mattleibow mattleibow reopened this Jun 11, 2021
@jeromelaban
Copy link
Contributor

You got lucky this time? Sweet 😁

@mattleibow mattleibow merged commit 80860aa into main Jun 11, 2021
@mattleibow mattleibow deleted the dev/uno-skia branch June 11, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants