-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SKXamlCanvas on Uno Platform SkiaSharp backends v2.0 (#1634) #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckends This enables SKXamlCanvas for Uno Platform's support for for GTK (Linux, Windows, macOS), WPF and Tizen, for Uno 3.6 and later.
…a-on-skia' into dev/uno-skia
# Conflicts: # samples/Basic/Uno/SkiaSharpSample.Android/SkiaSharpSample.Android.csproj # samples/Gallery/Uno/SkiaSharpSample.Wasm/SkiaSharpSample.Wasm.csproj
# Conflicts: # source/SkiaSharpSource.Linux.sln # source/SkiaSharpSource.Mac.sln
6 tasks
@mattleibow I've published a new build of Uno, 3.7.6 which will fix the invalid dependency you've seen. I've made the changes in a commit from your branch here: unoplatform@c9563e5, if you want to cherry pick :) |
Awesome, starting the build again. Hopefully this is the one! |
Close, I guess ;) Let me know how I can help! |
Woohoo ✅✅✅✅ ;) |
mattleibow
changed the title
[WIP] Building for #1634
Add support for SKXamlCanvas on Uno Platform SkiaSharp backends v2.0 (#1634)
Jun 3, 2021
4 tasks
You got lucky this time? Sweet 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Getting better builds for #1634