Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct MacCatalyst targets file name #1762

Merged
merged 2 commits into from
Aug 8, 2021
Merged

Conversation

mattleibow
Copy link
Contributor

Description of Change

The file name of the .targets file for the SkiaSharp.NativeAssets.MacCatalyst package was not renamed to match the package ID and thus never got imported.

This is a bug in the PR #1760

Bugs Fixed

  • The .targets file for maccatalyst are not imported.

API Changes
None.

Behavioral Changes

Mac Catalyst compilation now works.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow added this to In progress in v2.88.0 via automation Aug 8, 2021
@mattleibow mattleibow merged commit cacdbd7 into main Aug 8, 2021
v2.88.0 automation moved this from In progress to Done Aug 8, 2021
@mattleibow mattleibow deleted the dev/targets-filename branch August 8, 2021 22:53
@mattleibow mattleibow added this to the v2.88.0 milestone May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant