Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using the older gcc 6.2 and new llvm 10 compiler #1806

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Sep 11, 2021

Description of Change

Previously I had used the new compiler AND new GCC to use the new features, however, it seems this may not have actually been working or we got lucky.

After upgrading to skia m88, I notice that the Tizen apps are no longer running. I think either m80 just did not make use of certain symbols in the newer glibc. However, with m88, this is now happening. It might have been a bit deceiving because the app may have launched and rendered content because libSkiaSharp is actually bundled on the Tizen device - at least my watch has it.

The new approach is to use the new compilers still, but the old GCC and work around the features needed in the code.

The even better solution would be to have 2 versions of the library built for different versions of Tizen. However, that is for a new PR.

Bugs Fixed

  • The libSkiaSharp.so not being loaded because it depended on a newer glibc

API Changes

None.

Behavioral Changes

Should not be as this was the compiler we were using previously, however, there may be some slight perf decreases if there were any optimizations done in headers.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow changed the title Build using the older llvm-4.0 compiler Build using the older gcc 6.2 and new llvm 10 compiler Sep 11, 2021
@mattleibow mattleibow merged commit 5d1f324 into main Sep 12, 2021
@mattleibow mattleibow deleted the dev/tizen branch September 12, 2021 05:18
@mattleibow mattleibow added this to the v2.88.0 milestone May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant