Wrap and use SKMatrix4x4 #1864
Closed
Wrap and use SKMatrix4x4 #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now just SKCanvas
OneEyeMaker
reviewed
Dec 18, 2021
| public static SKPoint operator * (SKPoint pt, float sz) => | ||
| pt * new SKPoint (sz, sz); | ||
| public static SKPoint operator * (float sz, SKPoint pt) => | ||
| new SKPoint (sz, sz) + pt; |
|
No longer needed as in skia v3 we are using SKM44 everywhere and I took a shortcut and it is a wrapper for Matrix4x4 from System.Numerics. Probably losing out with the conversion, but we can do something later - maybe copy the implementation and use the same intrinsics. But with implicit converters, it is far less wasteful than interop with C... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now just SKCanvas
Description of Change
Bugs Fixed
API Changes
Behavioral Changes
PR Checklist