[android] don't include .so files in class libraries #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/android#5776
Fixes: dotnet/android#6545
If you do:
<PackageReference Include="SkiaSharp" Version="2.80.3" />
You end up with 13MB
.dll
file with C# code inside! The classlibrary is redistributing the SkiaSharp native libraries.
$(ShouldIncludeNativeSkiaSharp)
should default toFalse
for classlibraries.
To test this change, I manually edited:
Now my class library is 76,800 bytes.
When consuming this class library in an Android application project,
everything should still work as expected. However, the application
will need to reference SkiaSharp -- which is actually ideal.
API Changes
None
PR Checklist