Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the "classic" projects #2092

Merged
merged 23 commits into from
Jun 2, 2022
Merged

Merge the "classic" projects #2092

merged 23 commits into from
Jun 2, 2022

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Jun 1, 2022

Description of Change

Replace all the "classic" SkiaSharp.* and HarfBuzzSharp.* projects with a single one. This makes merging the #2091 PR much easier since we will need to add 14 projects or just 4 if we do this.

One day I will do the same for the Xamarin.Forms and SkiaSharp.Views projects, but for now this is just the core.

And in the very nice future we can just delete these projects and just use .NET 6 - but that is probably 10 years away.

commit a699d1ec3e3a5a6cbfffccb8c345da9b8235d5fe
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 18:23:18 2022 +0200

    revert skottie stuff

commit 9e8c4da
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 18:18:46 2022 +0200

    Merge the classic projects

commit db98562
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 16:56:07 2022 +0200

    build classic

commit 5129e2b
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 10:31:10 2022 +0200

    make iOS happy

commit 85fa204
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 09:51:09 2022 +0200

    sln

commit ecd1a45
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 01:57:30 2022 +0200

    that too

commit eb5449f
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 01:45:34 2022 +0200

    nuspec

commit 4330c93
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 01:38:30 2022 +0200

    The tests

commit 42154a8
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 01:24:00 2022 +0200

    ws

commit 44ea2aa
Author: Matthew Leibowitz <mattleibow@live.com>
Date:   Wed Jun 1 01:22:52 2022 +0200

    Move Skottie into a new package
@mattleibow

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@mattleibow

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@mattleibow

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

/azp run SkiaSharp

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow mattleibow marked this pull request as ready for review June 2, 2022 17:00
@mattleibow mattleibow merged commit ff5239a into main Jun 2, 2022
@mattleibow mattleibow deleted the dev/classic branch June 2, 2022 17:02
@mattleibow mattleibow added this to the v2.88.1 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant