-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the "classic" projects #2092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit a699d1ec3e3a5a6cbfffccb8c345da9b8235d5fe Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 18:23:18 2022 +0200 revert skottie stuff commit 9e8c4da Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 18:18:46 2022 +0200 Merge the classic projects commit db98562 Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 16:56:07 2022 +0200 build classic commit 5129e2b Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 10:31:10 2022 +0200 make iOS happy commit 85fa204 Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 09:51:09 2022 +0200 sln commit ecd1a45 Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 01:57:30 2022 +0200 that too commit eb5449f Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 01:45:34 2022 +0200 nuspec commit 4330c93 Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 01:38:30 2022 +0200 The tests commit 42154a8 Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 01:24:00 2022 +0200 ws commit 44ea2aa Author: Matthew Leibowitz <mattleibow@live.com> Date: Wed Jun 1 01:22:52 2022 +0200 Move Skottie into a new package
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run SkiaSharp |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Replace all the "classic" SkiaSharp.* and HarfBuzzSharp.* projects with a single one. This makes merging the #2091 PR much easier since we will need to add 14 projects or just 4 if we do this.
One day I will do the same for the Xamarin.Forms and SkiaSharp.Views projects, but for now this is just the core.
And in the very nice future we can just delete these projects and just use .NET 6 - but that is probably 10 years away.