Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the version of gn that works on old Apline #2711

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

mattleibow
Copy link
Contributor

Description of Change

The new versions of gn require C++20 which is not easily available on the very old Alpine.

Bugs Fixed

  • CI stopped working

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

The new versions of gn require C++20 which is not easily available on the very old Alpine.
@mattleibow mattleibow added the backport/release/2.x Backport this PR to release/2.x label Jan 12, 2024
@mattleibow mattleibow merged commit 9274aee into main Jan 12, 2024
2 of 3 checks passed
@mattleibow mattleibow deleted the dev/alpine-main branch January 12, 2024 18:24
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
The new versions of gn require C++20 which is not easily available on the very old Alpine.

(cherry picked from commit 9274aee)
mattleibow added a commit that referenced this pull request Jan 12, 2024
The new versions of gn require C++20 which is not easily available on the very old Alpine.

(cherry picked from commit 9274aee)

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release/2.x Backport this PR to release/2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant