Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Unsafe.As for better perf #2780

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Use Unsafe.As for better perf #2780

merged 3 commits into from
Mar 4, 2024

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Mar 2, 2024 •
edited
Loading

Description of Change

Using Unsafe.As provides almost double the perf improvement - see the issue.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

mono/skia#120

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow mentioned this pull request Mar 4, 2024
Merged
3 tasks
@mattleibow mattleibow merged commit 7ebc1f0 into main Mar 4, 2024
1 of 2 checks passed
@mattleibow mattleibow deleted the dev/matrix-perf branch March 4, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate the conversion between SKMatrix44 and Matrix4x4
1 participant
@mattleibow